RN: Suppress Lint Error in ReactNativePrivateInterface
#51438
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Migrates files to use ESM to mitigate the existing lint warning. I am suppressing `RelativeImageStub` to preserve compatibility with the dynamic asset exports generated by Metro (i.e. not ESM with `default` exports). Changelog: [Internal] Reviewed By: SamChou19815 Differential Revision: D74943031
Summary: Migrates files to use ESM to mitigate the existing lint warning. Changelog: [Internal] Differential Revision: D74949792
Summary: The `ReactNativePrivateInterface` module needs to continue using `module.exports` in order to lazily import dependencies. For now, we just suppress the `lint/no-commonjs-exports` lint rule. Changelog: [Internal] Differential Revision: D74949839
facebook-github-bot
added
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D74949839 |
Contributor
|
This pull request has been merged in 4434707. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
The
ReactNativePrivateInterfacemodule needs to continue usingmodule.exportsin order to lazily import dependencies.For now, we just suppress the
lint/no-commonjs-exportslint rule.Changelog:
[Internal]
Differential Revision: D74949839